Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317795 - Problem when cross-referenced diagrams are automatically resolved
Summary: Problem when cross-referenced diagrams are automatically resolved
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Gef3d (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Jens Von Pilgrim CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-24 05:39 EDT by Jens Von Pilgrim CLA
Modified: 2021-03-23 18:16 EDT (History)
0 users

See Also:


Attachments
mylyn/context/zip (2.26 KB, application/octet-stream)
2010-06-24 05:43 EDT, Jens Von Pilgrim CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Von Pilgrim CLA 2010-06-24 05:39:41 EDT
Given a model A which contains cross-references to a model B. Both models can be visualized by a nested editor withing a multi-editor. When model A is loaded and a cross reference, also known as inter-model connection, is to be created, this may lead to automatically loading of model B. This could lead to recursive calls of refreshChildren (in MultiEditorContainerEditPart), as the cross reference is only resolved during a refreshChildren call. If that happens, the resursively called refreshChildren causes new edit parts to be created for model elements which were already created in the first refreshChildren.
Comment 1 Jens Von Pilgrim CLA 2010-06-24 05:43:36 EDT
MultiEditorModelContainerEditPart simply called refreshChildren when new model elements (i.e. nested editor's diagrams) were added. This caused the recursive call of refreshChildren as described by that bug report. This is fixed now by avoiding calling refreshChildren on model changes (in propertyChanged), instead edit parts are added, removed or changed as needed without (re-) evaluating all child edit parts.
Comment 2 Jens Von Pilgrim CLA 2010-06-24 05:43:39 EDT
Created attachment 172586 [details]
mylyn/context/zip