317751 – Details and Mark as menu on attachment shows on all connectors

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317751 - Details and Mark as menu on attachment shows on all connectors

Summary: Details and Mark as menu on attachment shows on all connectors

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P2 major (vote)
Target Milestone:	3.4.1
Assignee:	Frank Becker
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2010-06-23 17:26 EDT by Shawn Minto
Modified:	2010-07-13 16:49 EDT (History)
CC List:	2 users (show)

See Also:

Attachments
commited patch (31.79 KB, patch) 2010-07-10 10:44 EDT, Frank Becker	no flags	Details \| Diff
mylyn/context/zip (10.75 KB, application/octet-stream) 2010-07-10 10:44 EDT, Frank Becker	no flags	Details
commited patch (35.46 KB, patch) 2010-07-11 10:39 EDT, Frank Becker	eclipse: review?	Details \| Diff
mylyn/context/zip (49.47 KB, application/octet-stream) 2010-07-11 10:39 EDT, Frank Becker	no flags	Details
backported patch (5.20 KB, patch) 2010-07-13 14:51 EDT, Steffen Pingel	no flags	Details \| Diff
mylyn/context/zip (23.74 KB, application/octet-stream) 2010-07-13 14:51 EDT, Steffen Pingel	no flags	Details
additional changes for head (2.68 KB, patch) 2010-07-13 14:55 EDT, Steffen Pingel	no flags	Details \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Shawn Minto

2010-06-23 17:26:16 EDT

Bugzilla contributes the "Details..." and "Mark As" menu to task attachments, but it uses an object contribution for ITaskAttachment which means that it will show up for all attachments on any connector (i.e. JIRA), but not do anything.  I think that this should be converted to a command and then visibility rules can be used to ensure that it only shows for Bugzilla tasks.

Comment 1 Steffen Pingel

2010-06-23 17:33:58 EDT

Rob, Frank, this is a usability problem that needs to be addressed for 3.4.1.

Comment 2 Steffen Pingel

2010-07-08 19:51:15 EDT

Frank, I'll tentatively assign this to you. Please feel free to assign it to Rob if you don't get to it.

Comment 3 Frank Becker

2010-07-10 10:44:28 EDT

Created attachment 173934 [details]
commited patch

Steffen,

can you do the backport?

Comment 4 Frank Becker

2010-07-10 10:44:30 EDT

Created attachment 173935 [details]
mylyn/context/zip

Comment 5 Steffen Pingel

2010-07-11 00:17:54 EDT

I would prefer if we could use a menu contribution that was only enabled for Bugzilla attachments instead of extending an internal part. This should work through using a property tester. I'll try to post an example next week.

Comment 6 Frank Becker

2010-07-11 03:26:10 EDT

(In reply to comment #5)
> I would prefer if we could use a menu contribution that was only enabled for
> Bugzilla attachments instead of extending an internal part. This should work
> through using a property tester. I'll try to post an example next week.

Steffen,

I try to use AbstractSourceProvider and hope that I can do this today.

Comment 7 Frank Becker

2010-07-11 10:39:48 EDT

Created attachment 173975 [details]
commited patch

We now use an IActionFilter for TaskAttachment with the following defined names.

* ConnectorKind
* ContentType
* isDeprecated
* isPatch

Do you think that we still need others?

Comment 8 Frank Becker

2010-07-11 10:39:51 EDT

Created attachment 173976 [details]
mylyn/context/zip

Comment 9 Steffen Pingel

2010-07-12 18:38:13 EDT

Thanks! That patch looks good. I'll look into back-porting the changes. I don't think we need anymore than these properties.

Comment 10 Steffen Pingel

2010-07-13 14:51:51 EDT

Created attachment 174207 [details]
backported patch

Comment 11 Steffen Pingel

2010-07-13 14:51:53 EDT

Created attachment 174208 [details]
mylyn/context/zip

Comment 12 Steffen Pingel

2010-07-13 14:55:31 EDT

Created attachment 174209 [details]
additional changes for head

Comment 13 Steffen Pingel

2010-07-13 14:55:54 EDT

Thanks Frank! Should be all backported now.

Comment 14 Frank Becker

2010-07-13 16:37:40 EDT

fixed a typo
               <objectState name="ConnectorKind" value="bugzilla"></objectState>
changed to
               <objectState name="connectorKind" value="bugzilla"></objectState>

Comment 15 Steffen Pingel

2010-07-13 16:49:50 EDT

Thanks for catching that!