Description Zac Wolfe 2010-06-23 15:56:54 EDT

org.eclipse.gmf.runtime.diagram.ui.resources.editor.parts.DiagramDocumentEditor$PropertyChangeListener  needs to do null checking or allow the user to override the behavior.  

The problem happens when the PropertyChangeListener is invoked while there is no active page (eg. when a ProgressMonitor has focus).  

This code: 

if (PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage().getActivePart() == DiagramDocumentEditor.this) {
				String property = event.getProperty();
...


Should be changed to something like:

if (PlatformUI.getWorkbench().getActiveWorkbenchWindow() != null && PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage() != null && PlatformUI.getWorkbench().getActiveWorkbenchWindow().getActivePage().getActivePart() == DiagramDocumentEditor.this) {
...