Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317646 - [refactoring] [plan] Problems with AspectRenameParticipant
Summary: [refactoring] [plan] Problems with AspectRenameParticipant
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: Core (show other bugs)
Version: 2.0.2   Edit
Hardware: Macintosh Mac OS X
: P3 critical (vote)
Target Milestone: 2.1.0   Edit
Assignee: Andrew Eisenberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 19:27 EDT by Andrew Eisenberg CLA
Modified: 2010-06-22 23:50 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Eisenberg CLA 2010-06-22 19:27:57 EDT 
Some problems have been found with the AspectRenameParticipant.  When a type that is referenced in an aspect is renamed, the AspectRenameParticipant kicks in.  In the past this rename participant tried to rename all references to the type, but since the latest changes in refactoring, this causes problems since some references (ie- standard java references) will be found by java search.  Other references must be found by the AspectRenameParticipant.  These are the references inside pcds, ITD names, and declare statements.

We need to ensure that all duplicate references are removed before they are added to the text edit tree.
Comment 1 Andrew Eisenberg CLA 2010-06-22 19:29:41 EDT 
Committed a first pass at these changes.  I completely refactored AspectRenameParticipant so that now it is using a more modern API, it is much shorter, and properly uses the LTK Change APIs.

This appears to be working when playing around in the workspace.  I need to update the tests to reflect these changes.  Currently, the tests in this area are disabled.
Comment 2 Andrew Eisenberg CLA 2010-06-22 23:50:42 EDT 
Tests committed now.