Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317644 - ROV - Issue with ControllerMap and removing controller
Summary: ROV - Issue with ControllerMap and removing controller
Status: CLOSED FIXED
Alias: None
Product: RTSC
Classification: Technology
Component: Rta (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Chris McCormick CLA
QA Contact:
URL:
Whiteboard: 3.20.01
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 17:53 EDT by Chris McCormick CLA
Modified: 2011-06-20 14:43 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McCormick CLA 2010-06-22 17:53:58 EDT 
The ROVController only adds itself to the ControllerMap if it successfully launches, but it will try to remove itself from the ControllerMap when 'shutdown' is called. This creates the possibility of attempting to remove the controller even when it hasn't been added.

The solution is to improve the ControllerMap APIs to protect against this.

This bug leads to an exception being generated by ROV. This bug becomes especially important in the context of the changes to ROV which cause ROV to be shutdown whenever the ROV window is closed. Those changes make it more likely for someone to encounter this.
Comment 1 Chris McCormick CLA 2010-06-22 19:43:45 EDT 
Fixed in rov-c23
Comment 2 Dave Russo CLA 2010-07-27 16:45:11 EDT 
Verified by Branavan per email given below:


________________________________________
From: Karunamoorthy, Branavan 
Sent: Tuesday, July 27, 2010 1:07 PM
To: Mookerjee, Amit
Cc: McCormick, Chris; Ali, Imtaz
Subject: RE: Fix verify of 317644

Yep the error when shutting down the ROV without loading a program doesn’t happen anymore on the CCS CCS4.2.0.09010 build. 

Thanks
Branavan. 


________________________________________
From: Mookerjee, Amit 
Sent: Tuesday, July 27, 2010 12:19 PM
To: Karunamoorthy, Branavan
Cc: McCormick, Chris; Ali, Imtaz
Subject: Fix verify of 317644

Hi Branavan,
I have been advised that you maybe able to verify a ROV fix – ECL317644 -that Chris did sometime back. Will you have sometime to verify the fix for this problem?
The fix should be available in XDCtools 3.20.01.51 which I believe will be included in the latest CCS4.2 builds.

Regards
Amit
Comment 3 Dave Russo CLA 2011-06-20 14:43:42 EDT 
Shipped in XDCtools 3.20.01