Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317642 - [Help] Restore defaults button does not read remoteHelpPreferred preference correctly. - Fix in Eclipse 3.7
Summary: [Help] Restore defaults button does not read remoteHelpPreferred preference c...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 17:40 EDT by Chris Goldthorpe CLA
Modified: 2011-10-03 06:20 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Goldthorpe CLA 2010-06-22 17:40:39 EDT 
+++ This bug was initially created as a clone of Bug #316011 +++

Build Identifier: eclipse-SDK-I20100603-1500-win32

When clicking the Restore Defaults button, Eclipse reads the default preferences for remote help, and loads them in.  However, when reading the value for the remote help preferred setting, when setting the correct values for the "Include remote help but give local help priority" and "Include remote help but give local help priority", the preference is not negated properly for the local help priority setting.  

searchLocalHelpFirst.setSelection(new DefaultPreferenceFileHandler().isRemoteHelpPreferred());
searchLocalHelpLast.setSelection(new DefaultPreferenceFileHandler().isRemoteHelpPreferred());

The searchLocalHelpFirst should negate the isRemoteHelpPreferred() value:

searchLocalHelpFirst.setSelection(!(new DefaultPreferenceFileHandler().isRemoteHelpPreferred()));

The bad behavior is that if remote help preferred is the default, both boxes will have that value which is incorrect.

Reproducible: Always

Steps to Reproduce:
1. Contribute to the default preferences for remote help
2. Click Restore Defaults
3. Both radios always have the same value
Comment 1 Chris Goldthorpe CLA 2010-06-22 17:43:05 EDT 
The patch from Bug #316011 has been applied - Fixed.