Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317621 - Empty product id results in "null" root artifact for the .eclipseproduct
Summary: Empty product id results in "null" root artifact for the .eclipseproduct
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 13:39 EDT by Andrew Niefer CLA
Modified: 2010-06-22 14:23 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2010-06-22 13:39:55 EDT 
When generating the .eclipseproduct for a product built with p2, we create an IU named product.getProductId() + ".root.feature".  If the product does not have an id defined, then we get "null.root.feature".

We should instead use getId() which returns the uid if defined, otherwise the normal id.
Comment 1 Andrew Niefer CLA 2010-06-22 13:49:12 EDT 
Also, this id is being used as a key to get this extra IU required by the product, the ProductGenerator was actually using product.getId(), so if the uid != id, then we would be missing the .eclipseproduct file.
Comment 2 Andrew Niefer CLA 2010-06-22 14:23:31 EDT 
fixed