Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317598 - Delete extra createArtifactDescriptor method on PublisherHelper
Summary: Delete extra createArtifactDescriptor method on PublisherHelper
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 10:59 EDT by John Arthorne CLA
Modified: 2010-09-16 12:18 EDT (History)
1 user (show)

See Also:

Attachments
Patch for PDE build (1.13 KB, patch)
2010-06-22 11:01 EDT, John Arthorne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2010-06-22 10:59:47 EDT 
PublisherHelper has a method:

public static IArtifactDescriptor createArtifactDescriptor(IArtifactRepository artifactRepo, IArtifactKey key, File pathOnDisk) {

This is replaced by a more powerful method that passes in the IPublisherInfo rather than just the repository. This allows it to honour IPublisherInfo option settings while creating the artifact.

References to the old method should switch to use the new method. Then the old method can be deleted.
Comment 1 John Arthorne CLA 2010-06-22 11:01:10 EDT 
Created attachment 172424 [details]
Patch for PDE build

Andrew can you release this patch for PDE build?
Comment 2 Andrew Niefer CLA 2010-06-22 17:28:02 EDT 
ok patch is released to build.
Comment 3 John Arthorne CLA 2010-09-01 15:39:13 EDT 
Released.
Comment 4 DJ Houghton CLA 2010-09-16 12:18:32 EDT 
There was a problem with tagging HEAD so this fix won't appear in integration builds until the first build after 3.7 M2.