Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317580 - The functionality of ScopingNode#findImportingScopes is incorrect.
Summary: The functionality of ScopingNode#findImportingScopes is incorrect.
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: 6.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 6.0.1   Edit
Assignee: Jeffrey Overbey CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-22 09:51 EDT by Stas Negara CLA
Modified: 2011-05-14 06:48 EDT (History)
1 user (show)

See Also:

Attachments
Patch for Bugs 317580 and 317583 (7.45 KB, patch)
2010-06-22 14:27 EDT, Jeffrey Overbey CLA 		g.watson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stas Negara CLA 2010-06-22 09:51:26 EDT 
ScopingNode#findImportingScopes returns not only the importing scopes of a particular ScopingNode, but also all importing scopes of those scopes that are imported in this ScopingNode. Additionally, this method looks for importing scopes in an inefficient manner, which makes it very slow.
Comment 1 Jeffrey Overbey CLA 2010-06-22 14:27:17 EDT 
Created attachment 172448 [details]
Patch for Bugs 317580 and 317583
Comment 2 Jeffrey Overbey CLA 2010-06-22 14:31:26 EDT 
Thanks, Stas.  I have committed the fix to HEAD (Photran 7.0) as well as the ptp_4_0 branch (Photran 6.0.1).