Description John Cortell 2010-06-21 18:34:09 EDT

AbstractFinalLaunchSequence derivates specifies a minimum set of TCF peer attributes to indicate what agent the launch should use. The launch sequence respects the entire set when looking through the already discovered peers[1], and for determining what agent-launcher to use otherwise[2]. But after asking the agent-launcher to do its thing, it tries to match newly discovered peers based only on the user-friendly peer name (IPeer.ATTR_NAME).

In other words, 

  public void peerAdded(IPeer peer) {
      if (peer.getName().equals(descriptor.getPeerName())) {
          waitForPeer.setData(peer);
      }
  }

is inadequate. For starters, whose to say if the AbstractFinalLaunchSequence derivative even specified IPeer.ATTR_NAME as a qualifying attribute? And even if it did, how about all the other attributes it may have specified?


[1] See the call to tcfServiceManager.getRunningPeers() in AbstractFinalLaunchSequence.findPeer(RequestMonitor)

[2] See the call to tcfServiceManager.getRegisteredAgents() in AbstractFinalLaunchSequence.findPeer(RequestMonitor)