Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317521 - make attachments comment optional
Summary: make attachments comment optional
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 17:31 EDT by Thomas Ehrnhoefer CLA
Modified: 2010-07-09 20:54 EDT (History)
2 users (show)

See Also:

Attachments
patch v1 (5.01 KB, patch)
2010-06-21 17:46 EDT, Thomas Ehrnhoefer CLA 		thomas.ehrnhoefer: review?
Details | Diff
mylyn/context/zip (28.02 KB, application/octet-stream)
2010-06-21 17:46 EDT, Thomas Ehrnhoefer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2010-06-21 17:31:16 EDT 
Some repositories don't support comments. The attachments wizard page should have a "setNeedsComment" to show/hide the comments editor
Comment 1 Thomas Ehrnhoefer CLA 2010-06-21 17:46:14 EDT 
Created attachment 172377 [details]
patch v1
Comment 2 Thomas Ehrnhoefer CLA 2010-06-21 17:46:17 EDT 
Created attachment 172378 [details]
mylyn/context/zip
Comment 3 Steffen Pingel CLA 2010-07-02 14:20:23 EDT 
Thanks for the patch Thomas. Currently, repository connectors that do not support comments are not very well supported by the framework. The attach context dialog for instance makes the same assumption that it is always possible to submit a comment along with an attachment.

It seems to me that support for comments should be a capability on AbstractRepositoryConnector or part of the attachment data model rather than something that is handled on the UI level. What are your thoughts?
Comment 4 Thomas Ehrnhoefer CLA 2010-07-03 16:00:39 EDT 
Sure, that sounds reasonable. I will rewrite the patch
Comment 5 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn