Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317505 - [NLS] Accessibility: Labels of lists are not read by JAWS in several wizards
Summary: [NLS] Accessibility: Labels of lists are not read by JAWS in several wizards
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords:
Depends on: 315679
Blocks:
  Show dependency tree
 
Reported: 2010-06-21 15:13 EDT by Carl Anderson CLA
Modified: 2010-06-28 18:33 EDT (History)
5 users (show)

See Also:
ccc: review+

Attachments
The java facet part of 315679 (3.37 KB, patch)
2010-06-21 15:15 EDT, Carl Anderson CLA 		no flags Details | Diff
Patch v2 (3.28 KB, patch)
2010-06-23 17:02 EDT, Konstantin Komissarchik CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Anderson CLA 2010-06-21 15:13:13 EDT 
Konstantin would like a separate bug to track the inclusion of this change into the Faceted Project Framework.

Please note that PMC approval was granted to bug 315679.  I would assume that that means that this bug is implicitly approved.

+++ This bug was initially created as a clone of Bug #315679 +++

Build Identifier: 321

1.- Open the wizards for EJB, APP client, Connector or dynamic web projects and go to the java facets page. Using the keyboard, and with JAWS started, tab to the list of source folders. The label is not read by JAWS
2.- Open the new EAR project wizard, and go to the Enterprise application page. Using the keyboard, and with JAWS started, tab to the list of modules. The label is not read by JAWS

Reproducible: Always
Comment 1 Carl Anderson CLA 2010-06-21 15:15:40 EDT 
Created attachment 172359 [details]
The java facet part of 315679
Comment 2 Carl Anderson CLA 2010-06-23 13:07:40 EDT 
I just committed the non-FacetedProjectFramework part of 315679.
The patch on this bug was part of the PMC approved patch, so no further approval should be necessary.

I am marking this as reviewed, simply because I am the Common Project lead, and I have reviewed this, and I believe that it is ready to go into WTP 3.2.1.
Comment 3 Konstantin Komissarchik CLA 2010-06-23 16:48:35 EDT 
There is a problem with this patch. I use Microsoft Inspect32 tool.

Before the patch, if I put focus on the table and the table has at least one item, the name is the label of that item. As I move focus between multiple table entries, the name changes to represent the selected item. The name of the parent (the table) is not set. This could cause confusion when table has items, but is a bigger issue when table has no items. In that case name of the selected widget will be "" on focus.

After the patch, the parent widget name is set correctly and the no item case works, however we've lost the ability to read the text of the selected items. No matter what I do, I cannot get inspect32 to show the item label.

I will look for a solution.
Comment 4 Konstantin Komissarchik CLA 2010-06-23 17:02:31 EDT 
Created attachment 172552 [details]
Patch v2

The trick is to check that childID is equals to -1 before setting the name. Other values of childID represent table items and we don't want to mess with the default behavior on those. 

Please re-review as appropriate. Also, all of my evaluation and changes have been based on using Inspect32 tool. If someone has access to JAWS, it would be good to confirm this separately as well.
Comment 5 Konstantin Komissarchik CLA 2010-06-28 18:33:37 EDT 
Released changes to WTP 3.2.1 and 3.3 streams along with fproj branch.