Comment 1 Andrew Overholt 2010-06-21 10:18:33 EDT

Created attachment 172332 [details]
screenshot

Screenshot

Comment 2 Andrew Overholt 2011-04-27 16:20:17 EDT

Created attachment 194207 [details]
potential fix

This patch may fix this issue.  What do you think, Markus?

Comment 3 Markus Knauer 2011-04-29 10:58:11 EDT

(In reply to comment #2)
> This patch may fix this issue.  What do you think, Markus?

I don't think so because

* the value from the epp.product file is only propagated to the plugin.xml if synchronize it manually with the product editor (the build does not do this, it just takes what is already in the branding plugin.xml - maybe this is a bit misleading)
* and then I *think* that removing the property doesn't help; I would try to solve it by setting another property startupMessageRect (see constants in IProductConstants)

This is something that affects most if not all packages. Let me see if I can find the settings from the SDK which we could apply to all packages then.

Comment 4 Markus Knauer 2011-05-26 12:00:32 EDT

First, moving to 'package content' because all packages are affected, not only the LinuxTools package.
Then, I compared the product definitions in the plugin.xml files:

org.eclipse.platform_3.7.0.v201105191138 defines both, startupMessageRect and startupProgressRect
          <property name="startupMessageRect"
                value="7,220,441,20"/>
          <property name="startupProgressRect"
                value="0,280,455,15"/>

The SDK uses in org.eclipse.sdk_3.7.0.v201105191138.jar the following values
          <property name="startupMessageRect"
                value="7,220,441,20"/>
          <property name="startupProgressRect"
                value="0,280,455,15"/> 
                
All EPP packages had only the startupProgressRect parameter with slightly different values, e.g. org.eclipse.epp.package.rcp_1.4.0.20110526-1025
         <property name="startupProgressRect"
               value="5,275,445,15">

I think we should use the same values as the Platform and the SDK (will create a patch in a minute).

Comment 5 Markus Knauer 2011-05-26 12:44:25 EDT

Created attachment 196677 [details]
splash screen adjustment (message and progress bar)

I will apply this patch very soon to CVS HEAD.
It changes for *all* packages the behaviour of the splash screen, in particular it adds

* to epp.product
   <splash
      startupProgressRect="0,280,455,15"   <= values changed (same as SDK build)
      startupMessageRect="7,220,441,20"   <= added 
      startupForegroundColor="C8D5EA" />  <= added
      
* to the plugin.xml
         <property
               name="startupForegroundColor"
               value="C8D5EA">
         </property>
         <property
               name="startupMessageRect"
               value="7,220,441,20">
         </property>
         <property
               name="startupProgressRect"
               value="0,280,455,15">
         </property>

The *JavaScript* package was a bit different. In general, the splash values in the epp.product are ignored by the epp build and only the values from the plugin.xml are taken into account at runtime. Usually these values are synchronized by the PDE tooling and the product editor. The JavaScript package had entries for all properties but with different values. If you are not satisfied with the new values from the SDK, please let me know.

Comment 6 Markus Knauer 2011-05-26 12:46:06 EDT

Adding David to this bug, because he needs to agree to the additional changes in the JavaScript package in comment #5.

Comment 7 Markus Knauer 2011-06-01 02:48:40 EDT

Looks much better now - I tested it with the LinuxTools and the RCP/RAP linux/gtk/x86_64 packages, but we need more testing on other platforms.

Comment 8 Andrew Overholt 2011-06-01 09:58:22 EDT

I'd offer but I run Linux Gtk x86_64 exclusively myself :)

Comment 9 Andrew Overholt 2011-06-01 11:21:22 EDT

I tested the build from yesterday and it looks good!  I'm on Fedora 15.

Comment 10 Markus Knauer 2011-06-24 07:16:33 EDT

Closing as FIXED.