Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317443 - eclipse.buildId not in configuration/config.ini any more
Summary: eclipse.buildId not in configuration/config.ini any more
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 09:48 EDT by Markus Keller CLA
Modified: 2010-06-23 08:58 EDT (History)
1 user (show)

See Also:

Attachments
patch (2.54 KB, patch)
2010-06-22 16:20 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-06-21 09:48:44 EDT 
N20100620-2000 (3.7 stream; Bugzilla 'Version' field does not yet offer 3.7)

The eclipse.buildId system property is not in eclipse/configuration/config.ini any more.

In 3.6, the config.ini contained this line:
eclipse.buildId=I20100608-0911

This also used to work fine for N-builds, e.g.:
eclipse.buildId=N20100530-2000


Consequences of this include:
- Error Log view does not show build ID any more
- 'Copy Build Id To Clipboard' command shows an error dialog:

org.eclipse.core.commands.ExecutionException: No build ID in this instance.
at org.eclipse.ui.internal.ide.commands.CopyBuildIdToClipboardHandler.execute(CopyBuildIdToClipboardHandler.java:40)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommandInContext(HandlerService.java:270)
at org.eclipse.ui.internal.quickaccess.CommandElement.execute(CommandElement.java:53)
at org.eclipse.ui.internal.quickaccess.QuickAccessDialog.handleElementSelected(QuickAccessDialog.java:708)
Comment 1 Markus Keller CLA 2010-06-21 09:53:10 EDT 
I guess I found the culprit in Platform/Releng:
/org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/sdk/builder/sdk.product 1.11 lost 3 properties at the end of the file.
Comment 2 Markus Keller CLA 2010-06-21 09:55:37 EDT 
Same omissions in
/org.eclipse.releng.eclipsebuilder/eclipse/buildConfigs/platform/platform.product
Comment 3 John Arthorne CLA 2010-06-22 16:01:33 EDT 
Bug 260328 strikes again.
Comment 4 Kim Moir CLA 2010-06-22 16:20:35 EDT 
Created attachment 172460 [details]
patch

I think the pde editor did this when I updated the version of the product.  It often has unexpected results because there are values in our product files that aren't supported. There is an existing bug for this issue.
Comment 5 Kim Moir CLA 2010-06-22 16:20:49 EDT 
tagged for N-build.
Comment 6 Markus Keller CLA 2010-06-23 07:05:34 EDT 
The sdk.product is back to version="3.6.0.@qualifier@" now. Should be 3.7.0.
Comment 7 Kim Moir CLA 2010-06-23 08:58:04 EDT 
And this is why the build failed. Sorry about this. I was creating the patch by comparing with another branch and inadvertently copied the part with the old product id.
Comment 8 Kim Moir CLA 2010-06-23 08:58:25 EDT 
This has been fixed for the next build.