Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317423 - [Model] Get rid of the AbstractContainers like PartDescriptorContainer, ...
Summary: [Model] Get rid of the AbstractContainers like PartDescriptorContainer, ...
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 07:57 EDT by Thomas Schindl CLA
Modified: 2010-06-23 10:16 EDT (History)
4 users (show)

See Also:

Attachments
Patch (65.62 KB, patch)
2010-06-21 08:56 EDT, Thomas Schindl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-21 07:57:33 EDT 
Some of the containers we defined where solely used by Application and our old Model-Contribution story and hence are "useless" now:
* PartDescriptorContainer
* BindingTableContainer

Stuff I'm unsure why we have containers are:
* TrimContributions
* MenuContributions
* ToolBarContributions

but to me it looks like they are only used by Application-class so beside that I guess they are abstract, right?
Comment 1 Thomas Schindl CLA 2010-06-21 08:00:01 EDT 
if we decide against removing them we should make them at least abstract (talking about the *Contribution classes)
Comment 2 Thomas Schindl CLA 2010-06-21 08:56:24 EDT 
Created attachment 172325 [details]
Patch

I just tried and removing them at this point in the cycle is probably too hard so I simply marked all of them interface=true, abstract=true

The only compiler error I saw when removing whole classes was that the reconciler was failing.
Comment 3 Thomas Schindl CLA 2010-06-22 14:09:44 EDT 
anyone a +1?
Comment 4 Thomas Schindl CLA 2010-06-23 10:16:43 EDT 
released to HEAD