Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317417 - [Model] StackElement should be abstract and interface
Summary: [Model] StackElement should be abstract and interface
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-21 07:16 EDT by Thomas Schindl CLA
Modified: 2010-06-23 10:11 EDT (History)
4 users (show)

See Also:

Attachments
patch (14.36 KB, patch)
2010-06-21 08:40 EDT, Thomas Schindl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-21 07:16:41 EDT 
StackElement is only a marker for improved containment hierarchies. We should at least make it abstract but also as an interface like WindowElement, ...
Comment 1 Thomas Schindl CLA 2010-06-21 08:40:41 EDT 
Created attachment 172323 [details]
patch

This patch will probably not apply inconjunction with the one from bug #317405
Comment 2 Thomas Schindl CLA 2010-06-22 14:09:30 EDT 
anyone a +1?
Comment 3 Eric Moffatt CLA 2010-06-22 15:10:06 EDT 
Tom, please no model changes now...

I agree that there have been a number of 'ad hoc' changes to the model as we try to meet the 4.0 SDK release date but I think we should wait until after we get this thing out before making any more changes that are not directly related to this task.

BTW, I'm in complete agreement that we should do a model redux very soon after we go out to pick up some of these defects.
Comment 4 Thomas Schindl CLA 2010-06-23 03:12:55 EDT 
This is a none breaking change it only declares an element abstract/interface nobody should create an instance of. I don't see how this could break something.

I'm not trying to bring in none breaking changes but e.g. the reflective editor and Yves generic stuff will allow you to create instance of this.
Comment 5 Thomas Schindl CLA 2010-06-23 10:11:32 EDT 
released to HEAD