Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317395 - Method org.eclipse.cdt.codan.core.param.FileScopeProblemPreference.exportPathList(String, IPath[]) concatenates strings using + in a loop
Summary: Method org.eclipse.cdt.codan.core.param.FileScopeProblemPreference.exportPath...
Status: RESOLVED WONTFIX
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 7.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-20 23:45 EDT by Meisam CLA
Modified: 2010-06-22 09:27 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Meisam CLA 2010-06-20 23:45:28 EDT 
This is a performance issue reported by Findbugs.

A StringBuffer can be used for achieving better performance.
Comment 1 Elena Laskavaia CLA 2010-06-21 12:11:51 EDT 
When I said open bugs for findbugs issues I meant BUGS. I am not going to change code that uses +. It reads better and it is not high impact code by any means - it only calls ones when prefers stored. Same about other "inefficiencies" such as keySet iterator.
Comment 2 Meisam CLA 2010-06-22 09:27:23 EDT 
Thanks for clarifying:) I'll report real bugs.