Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317376 - Compare view should show truncated commit reference, not full reference
Summary: Compare view should show truncated commit reference, not full reference
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-19 21:28 EDT by Alex Blewitt CLA
Modified: 2010-06-30 08:53 EDT (History)
1 user (show)

See Also:

Attachments
How http://egit.eclipse.org/r/#change,1008 looks like (130.29 KB, image/png)
2010-06-30 05:58 EDT, Mykola Nikishov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2010-06-19 21:28:08 EDT 
Build Identifier: EGit 0.8.4

When comparing resources from the history view, the comparison page shows a full commit reference. We should truncate this to something sensible in the title, and just leave the full version for the tooltip.

Reproducible: Always

Steps to Reproduce:
open a resource under EGit control
Go to 'history' view
Select two resources
Select 'compare with each other'
Note the title of the compare page is the name of the resource + full commit reference for the two trees
Comment 1 Alex Blewitt CLA 2010-06-19 21:45:25 EDT 
Pushed http://egit.eclipse.org/r/908 to review to fix
Comment 2 Alex Blewitt CLA 2010-06-30 04:33:02 EDT 
Pushed new change (abandoned old one) to 

http://egit.eclipse.org/r/1008
Comment 3 Mykola Nikishov CLA 2010-06-30 05:58:58 EDT 
Created attachment 173075 [details]
How http://egit.eclipse.org/r/#change,1008 looks like
Comment 4 Stefan Lay CLA 2010-06-30 08:53:16 EDT 
Fixed with 1da2a96cbdf7711f7e99132229124179c779ee94