Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317336 - TCFDataModel calling TCF service on non-TCF thread
Summary: TCFDataModel calling TCF service on non-TCF thread
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-edc (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ken Ryall CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-18 16:17 EDT by John Cortell CLA
Modified: 2010-06-21 14:11 EDT (History)
0 users

See Also:
ken.ryall: review+

Attachments
Fix (2.80 KB, patch)
2010-06-18 16:18 EDT, John Cortell CLA 		john.cortell: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-06-18 16:17:07 EDT 
This happens in TCFDataModel.buildDataModel(IProgressMonitor). My guess as to why this went undetected is that assertions were not enabled in the runtime workbench.

Also, the same code fails to complete the progress monitor it is given.
Comment 1 John Cortell CLA 2010-06-18 16:18:09 EDT 
Created attachment 172255 [details]
Fix

Committed to HEAD. Ken, please review.
Comment 2 John Cortell CLA 2010-06-18 16:18:46 EDT 
Fixed.
Comment 3 CDT Genie CLA 2010-06-18 16:23:05 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 317336: TCFDataModel calling TCF service on non-TCF thread

[*] TCFDataModel.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/edc/org.eclipse.cdt.debug.edc.ui/src/org/eclipse/cdt/debug/edc/internal/ui/views/TCFDataModel.java?root=Tools_Project&r1=1.1&r2=1.2
Comment 4 Ken Ryall CLA 2010-06-21 14:11:53 EDT 
Thanks John, I did forget to turn on assertions in my new workspace.