Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317316 - [releng] Need to build e4 rcp source feature
Summary: [releng] Need to build e4 rcp source feature
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-18 12:22 EDT by Paul Webster CLA
Modified: 2010-06-30 14:22 EDT (History)
3 users (show)

See Also:

Attachments
Add e4.rcp.source feature v01 (5.17 KB, patch)
2010-06-24 11:03 EDT, Paul Webster CLA 		no flags Details | Diff
patch (2.30 KB, patch)
2010-06-24 14:04 EDT, Kim Moir CLA 		no flags Details | Diff
another patch (2.77 KB, patch)
2010-06-24 16:57 EDT, Kim Moir CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-18 12:22:36 EDT 
Our e4 rcp feature currently doesn't define a source feature.

PW
Comment 1 Paul Webster CLA 2010-06-24 11:03:42 EDT 
Created attachment 172621 [details]
Add e4.rcp.source feature v01

Kim, should it  be enough to list the e4.rcp.source feature in the rcp.sdk feature, so it gets autogenerated?

PW
Comment 2 Kim Moir CLA 2010-06-24 11:29:38 EDT 
Paul,  the rcp.sdk feature isn't used anymore. I just removed it from the map to avoid confusion the future.  The source features are generated from product files.  I'll attach a patch.
Comment 3 Kim Moir CLA 2010-06-24 14:04:42 EDT 
Created attachment 172658 [details]
patch

I'll release this patch and try a test build.
Comment 4 Kim Moir CLA 2010-06-24 16:57:36 EDT 
Created attachment 172690 [details]
another patch
Comment 5 Kim Moir CLA 2010-06-24 17:07:04 EDT 
Verified in test build.
Comment 6 Kim Moir CLA 2010-06-24 17:07:50 EDT 
Forgot the test build link
https://build.eclipse.org/hudson/job/eclipse-e4-test/130/
Comment 7 Paul Webster CLA 2010-06-25 08:43:21 EDT 
I did something in build #131, I might have broken it.  I've tried reverting the map file and running 132 now.

PW