Comment 1 Ashley Kasza 2010-06-18 12:44:16 EDT

Created attachment 172233 [details]
same patch except with updated plugin.xml

This is the same patch as the one previously posted, except including the modified plugin.xml file.

Comment 2 Jeffrey Overbey 2010-06-18 17:36:39 EDT

Thanks.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 3 Jeffrey Overbey 2010-06-22 20:56:56 EDT

Ashley -- Reassigning this to you temporarily while you make the changes we discussed today.  Please reassign to me after you have a new patch.  Thanks.

Comment 4 Ashley Kasza 2010-06-23 11:20:19 EDT

Created attachment 172515 [details]
updated Loop Unrolling

Made small changes (updated some error checking, and added handling of int expressions).

Comment 5 Ashley Kasza 2010-06-23 11:22:29 EDT

1. I wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,

2. I have the right to contribute the code to Eclipse, and

3. I have included the EPL license header in all source files.

Comment 6 Jeffrey Overbey 2010-06-23 12:19:53 EDT

Thanks.  This is significanly larger than 250 LOC (closer to 1000), so we will need to file a CQ.  I will wait until after the code review Friday in case there are other changes to make.

Comment 7 Ashley Kasza 2010-06-29 15:53:50 EDT

Created attachment 173041 [details]
Update for Loop Unrolling

Updated some preconditions, also fixed/changed some functionality.

Comment 8 Jeffrey Overbey 2010-06-29 16:12:16 EDT

CQ 4297 Submitted

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4297

Comment 9 Ashley Kasza 2010-06-30 12:34:45 EDT

Created attachment 173126 [details]
small update Loop Unrolling

Small fix.

Comment 10 Ashley Kasza 2010-07-14 11:05:45 EDT

Created attachment 174298 [details]
small bug fix

Updated a small bug fix

Comment 11 Jeffrey Overbey 2010-09-21 11:10:39 EDT

Created attachment 179322 [details]
Revised patch - renamed, messages committed

I committed the externalized strings and plugin.xml changes to CVS, but the
unit tests are not passing, so I did not commit the refactoring itself or the
test suite.  Ashley, could you please replace your sources from HEAD (i.e., get
rid of your local changes), then apply the REVISED patch (attached), and see
why the tests are failing?  When it is fixed, please attach a revised revised
patch.  Thanks.

Comment 12 Ashley Kasza 2010-09-21 15:42:49 EDT

Created attachment 179339 [details]
revised revised loop unroll

another small bug fix.

Comment 13 Jeffrey Overbey 2010-09-21 16:28:13 EDT

Committed to HEAD.  Thanks, Ashley!