Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317305 - [Compatibility] Menus have many separators in them
Summary: [Compatibility] Menus have many separators in them
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 317196 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-18 11:01 EDT by Paul Webster CLA
Modified: 2018-06-28 05:43 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2010-06-18 11:01:30 EDT 
Currently, a menu like the Run menu has 8 separators in a row.

We should not draw them.

PW
Comment 1 Paul Webster CLA 2010-06-18 11:03:49 EDT 
Phase 1: don't draw seps with visible==false
Released


PW
Comment 2 John Arthorne CLA 2010-06-18 11:22:15 EDT 
*** Bug 317196 has been marked as a duplicate of this bug. ***
Comment 3 Paul Webster CLA 2010-06-18 12:15:37 EDT 
phase 2: don't add multiple seps with the same name under the same menu
Released

PW
Comment 4 Paul Webster CLA 2010-06-18 12:17:46 EDT 
phase 3: don't draw a sep if the next sibling is a sep.

The main problems have been dealt with, we can open new bugs for the corner cases.

PW
Comment 5 Dani Megert CLA 2010-07-05 05:21:27 EDT 
I20100701-1105.

Most of the duplicate separators are gone but there's still one in the 'Navigate' menu. Also, the fix might have been too aggressive, see bug 318848.
Comment 6 Dani Megert CLA 2010-07-05 05:23:45 EDT 
Sorry, didn't read comment 4. Filed bug 318850 for the remaining issue.