Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317257 - Server view should call refreshServerContent() when server state changes
Summary: Server view should call refreshServerContent() when server state changes
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.2.2   Edit
Assignee: Angel Vera CLA
QA Contact: Angel Vera CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 20:32 EDT by Danny Ju CLA
Modified: 2017-10-11 16:34 EDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (846 bytes, text/plain)
2010-06-17 20:35 EDT, Danny Ju CLA 		no flags Details
Change was commented out in last patch (844 bytes, patch)
2010-06-17 20:38 EDT, Danny Ju CLA 		arvera: iplog+
arvera: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Danny Ju CLA 2010-06-17 20:32:44 EDT 
Build Identifier: I20100527-1700

We are extending Server View with a common-navigation-viewer.
<extension
      point="org.eclipse.ui.navigator.viewer">
   <viewerContentBinding
       viewerId="org.eclipse.wst.server.ui.ServersView">
	<includes>
	         <contentExtension pattern="oracle.eclipse.tools.weblogic.server.ui.ServersView.content.mbean">
	         </contentExtension>
	      </includes>
	   </viewerContentBinding>
</extension>  
The content of the viewer is retrieved from server when server is started and 
is expected to be removed from UI when server starts. 

It didn't seems to work in current version of Server View. Specificly
the viwer is not getting refreshed when server stops.

Debugging into the Server View source code, I believe a refreshServerContent() 
is missing in the server state change listener. (Proposed patch to follow)  

Reproducible: Always

Steps to Reproduce:
1. Extend org.eclipse.ui.navigator.navigatorContent  
2. Extend org.eclipse.ui.navigator.viewer and hook up into Server View
3. Start/Stop server and notice viewer not getting refreshed.
Comment 1 Danny Ju CLA 2010-06-17 20:35:17 EDT 
Created attachment 172177 [details]
Proposed patch
Comment 2 Danny Ju CLA 2010-06-17 20:38:04 EDT 
Created attachment 172178 [details]
Change was commented out in last patch
Comment 3 Danny Ju CLA 2010-07-22 13:39:39 EDT 
With the proposed patch ready for review, we'd like this be fixed
in Helios SR1 if possible.
Comment 4 Konstantin Komissarchik CLA 2010-07-22 14:12:25 EDT 
Bumping the severity to major as this is currently preventing us from integrating our content into the server view.
Comment 5 Angel Vera CLA 2010-07-26 13:53:12 EDT 
Looking into the patch, now. I got to do some investigation regarding async call that is occuring inside of refreshServerContent(server). There is some recent information that I have learned where it is possible to call deadlocks in some situations when using async calls.
Comment 6 Angel Vera CLA 2010-07-26 13:57:36 EDT 
David, I am adding you as a FYI. This one might be coming down for 3.2.1, if I understand what Danny refers as Helios SR1 and assuming there is a full PMC approval and that I don't see much of a risk after the concerns on comment #5
Comment 7 Angel Vera CLA 2010-07-26 14:04:14 EDT 
After talking to David, it seems that we are not allowing 3.2.1 changes any longer. Thus, this will have to wait until 3.2.2.
Comment 8 Angel Vera CLA 2010-08-23 14:07:19 EDT 
changes committed to 32M
Comment 9 Angel Vera CLA 2010-08-23 17:22:19 EDT 
Changes committed and released to 32M and HEAD(3.3)
Comment 10 Angel Vera CLA 2010-08-24 14:16:44 EDT 
Fixed.
Comment 11 Eclipse Genie CLA 2017-10-11 16:34:27 EDT 
New Gerrit change created: https://git.eclipse.org/r/108983