Comment 1 Mariano Mendez 2010-06-17 18:29:32 EDT

Created attachment 172170 [details]
refactorings source code patch

Comment 2 Mariano Mendez 2010-06-17 21:25:09 EDT

Created attachment 172182 [details]
legal issue fixed patch

Comment 3 Jeffrey Overbey 2010-06-18 17:36:03 EDT

Thanks.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 4 Mariano Mendez 2010-06-22 21:02:43 EDT

I confirm that

 1. I wrote 100% of the code without incorporating content from elsewhere or
 relying on the intellectual property of others,

 2. I have the right to contribute the code to Eclipse, and
 
 3. I have included the EPL license header in all source files?

Mariano

Comment 5 Jeffrey Overbey 2010-06-22 21:12:57 EDT

Thanks.  This patch is signifiantly larger than 250 LOC, so I will need to file a CQ for it.

Comment 6 Jeffrey Overbey 2010-06-28 11:35:58 EDT

Filed CQ 4294 - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4294

Comment 7 Jeffrey Overbey 2010-07-09 11:39:25 EDT

The CQ was approved.  I will check this into CVS soon.

Comment 8 Jeffrey Overbey 2010-07-15 11:10:09 EDT

Esfar, could you please convert the test suite for this refactoring to be
marker-based and then attach a revised patch?  It looks like he expects the
second test case to fail its initial(?) precondition check, and the other two
should pass.  Thanks.

Comment 9 Jeffrey Overbey 2010-07-15 11:11:26 EDT

Oops, I copy and pasted too much.  I don't actually know which tests are supposed to pass or fail.

Comment 10 ehuq24 2010-07-15 17:39:31 EDT

Created attachment 174455 [details]
Marker-based test suite for Replace Character * to Character (LEN=) refactoring

Comment 11 Jeffrey Overbey 2010-07-19 17:09:26 EDT

Thanks.  Esfar, for your test suite code, can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests),

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 12 ehuq24 2010-07-19 17:15:25 EDT

(In reply to comment #11)
> Thanks.  Esfar, for your test suite code, can you please confirm that
> 
> 1. you wrote 100% of the code without incorporating content from elsewhere or
> relying on the intellectual property of others (except for code from Mariano's
> original tests),
> 
> 2. you have the right to contribute the code to Eclipse, and
> 
> 3. you have included the EPL license header in all source files?

Yes,

1. I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others (except for code from Mariano's original tests),

2. I have the right to contribute code to Eclipse, and

3. I have included the EPL license header in all source files

Comment 13 Jeffrey Overbey 2010-07-19 17:23:31 EDT

Committed to CVS HEAD.  Thanks, Mariano and Esfar.