Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317240 - Refactoring: Add Identifier to End Statement - CQ 4296 (approved)
Summary: Refactoring: Add Identifier to End Statement - CQ 4296 (approved)
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Photran.Refactoring Engine (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 7.0   Edit
Assignee: Matthew Fotzler CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 16:17 EDT by Matthew Fotzler CLA
Modified: 2011-05-14 06:48 EDT (History)
1 user (show)

See Also:

Attachments
patch (26.19 KB, patch)
2010-06-17 16:20 EDT, Matthew Fotzler CLA 		com-eclipse-dot-org: iplog+
Details | Diff
fixed for no program statement case (26.32 KB, patch)
2010-06-28 09:38 EDT, Matthew Fotzler CLA 		g.watson: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Fotzler CLA 2010-06-17 16:17:49 EDT 
Build Identifier: 

The attached patch provides the Add Identifier to END Refactoring with test suite.  Works with subroutines, functions, modules, and programs.

Also includes changes to the AST nodes to determine whether the program unit was specified in the end statement or not.

Reproducible: Always
Comment 1 Matthew Fotzler CLA 2010-06-17 16:20:48 EDT 
Created attachment 172159 [details]
patch
Comment 2 Jeffrey Overbey CLA 2010-06-17 16:39:06 EDT 
Thanks.  Can you please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?
Comment 3 Matthew Fotzler CLA 2010-06-17 16:41:19 EDT 
Yes, I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, I have the right to contribute the code to Eclipse, and I have included the EPL license header in all source files.
Comment 4 Jeffrey Overbey CLA 2010-06-22 14:50:19 EDT 
This modifies about 500 lines of code, so I will need to file a CQ.
Comment 5 Matthew Fotzler CLA 2010-06-22 16:26:20 EDT 
I didn't address the case where there is no program statement.  Will submit patch soon.
Comment 6 Matthew Fotzler CLA 2010-06-28 09:38:41 EDT 
Created attachment 172905 [details]
fixed for no program statement case
Comment 7 Jeffrey Overbey CLA 2010-06-28 11:36:28 EDT 
Filed CQ 4296 - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4296
Comment 8 Jeffrey Overbey CLA 2010-09-21 11:31:40 EDT 
Committed to CVS.  Thanks, Matt!