Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317217 - IDisassemblyBackend.SetDebugContextResult frame-level field is extraneous
Summary: IDisassemblyBackend.SetDebugContextResult frame-level field is extraneous
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Ken Ryall CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 12:39 EDT by John Cortell CLA
Modified: 2010-06-18 12:38 EDT (History)
2 users (show)

See Also:
aleherb+eclipse: review+

Attachments
Fix (4.41 KB, patch)
2010-06-17 12:41 EDT, John Cortell CLA 		john.cortell: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Cortell CLA 2010-06-17 12:39:22 EDT 
IDisassemblyBackend.SetDebugContextResult has a frame-level field that may have been used at some point, but then became irrelevant. The type is internal, so I'd like to clean this up on HEAD.
Comment 1 John Cortell CLA 2010-06-17 12:41:01 EDT 
Created attachment 172140 [details]
Fix
Comment 2 John Cortell CLA 2010-06-17 12:41:23 EDT 
Toni, please review.
Comment 3 Anton Leherbauer CLA 2010-06-18 02:56:44 EDT 
Less code is always +1 ;-)
Comment 4 John Cortell CLA 2010-06-18 11:47:14 EDT 
Committed to HEAD and cdt_7_0
Comment 5 CDT Genie CLA 2010-06-18 12:38:12 EDT 
*** cdt cvs genie on behalf of jcortell ***
Bug 317217: IDisassemblyBackend.SetDebugContextResult frame-level field is extraneous

[*] DisassemblyBackendDsf.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java?root=Tools_Project&r1=1.8&r2=1.9

[*] IDisassemblyBackend.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java?root=Tools_Project&r1=1.1&r2=1.2
[*] DisassemblyBackendCdi.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java?root=Tools_Project&r1=1.11&r2=1.12

[*] DisassemblyBackendCdi.java 1.10.2.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/DisassemblyBackendCdi.java?root=Tools_Project&r1=1.10.2.1&r2=1.10.2.2

[*] IDisassemblyBackend.java 1.1.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/disassembly/dsf/IDisassemblyBackend.java?root=Tools_Project&r1=1.1&r2=1.1.2.1

[*] DisassemblyBackendDsf.java 1.8.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/internal/ui/disassembly/DisassemblyBackendDsf.java?root=Tools_Project&r1=1.8&r2=1.8.2.1