Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317210 - JSP discoverer : managing xml.Attribute rather than jsp.ComposedAttribute
Summary: JSP discoverer : managing xml.Attribute rather than jsp.ComposedAttribute
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9.0 M1   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 11:59 EDT by Fabien Giquel CLA
Modified: 2010-10-18 08:30 EDT (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
patch for Discoverer JSP about attributes creation (639.34 KB, patch)
2010-06-21 06:36 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
Update JSP discoverer tests about attributes creation evolution (6.38 KB, patch)
2010-06-21 06:38 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabien Giquel CLA 2010-06-17 11:59:17 EDT 
For showing xml attributes having a value composed of string parts and JSP expressions, the JSP metamodel has a ComposedAttribute metaclass.

The JSP discoverer creates jsp.ComposedAttribute instances where often simple xml.Attribute fit the need : no composed attribute values.
It is annoying for M2M tools (more navigation rules to write to access to values) for some JSP legacy without such composed attributes values.

For realization, if necessary, we may add a consolidation step after ANTLR process on created model.
Comment 1 Nicolas Guyomar CLA 2010-06-21 06:27:35 EDT 
Hi Fabien,

I manage to improve Attribute's discovery in the attached Patch as requested
I also updated the corresponding tests

The consolidation step was not necessary, I have modified the ANTLR Grammar

Regards
Nicolas
Comment 2 Nicolas Guyomar CLA 2010-06-21 06:36:55 EDT 
Created attachment 172316 [details]
patch for Discoverer JSP about attributes creation

Updated grammar for Modisco JEE/JSP Discoverer
xml.Attribute are differenciated from JSP.ComposedAttribute
Comment 3 Nicolas Guyomar CLA 2010-06-21 06:38:29 EDT 
Created attachment 172317 [details]
Update JSP discoverer tests about attributes creation evolution

Updated tests for MoDisco JEE/JSP Discoverer
Comment 4 Nicolas Guyomar CLA 2010-06-21 06:39:23 EDT 
Comment on attachment 172316 [details]
patch for Discoverer JSP about attributes creation

Forgot to check "patch"
Comment 5 Fabien Giquel CLA 2010-06-21 09:53:57 EDT 
Hi Nicolas,

thanks for your contribution.
could you make the usual confirmations about contribution rights via this bug ?

Fabien.
Comment 6 Nicolas Guyomar CLA 2010-06-21 10:04:44 EDT 
Hi,

1. I, Nicolas Guyomar, and others contributors listed in this bug, authored
100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards

Nicolas
Comment 7 Fabien Giquel CLA 2010-06-21 10:10:46 EDT 
The patchs have been commited into SVN.

Fabien.
Comment 8 Hugo Bruneliere CLA 2010-10-04 13:44:39 EDT 
The patches have been successfully applied.