This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 317201 - key assist (Ctrl+Shift+L) does not work
Summary: key assist (Ctrl+Shift+L) does not work
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.1 RC1   Edit
Assignee: Jesse CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
: 332213 340320 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-17 11:19 EDT by Dani Megert CLA
Modified: 2011-05-16 09:34 EDT (History)
7 users (show)

See Also:

Attachments
Work in Progress ... keyAssist v01 (28.26 KB, patch)
2010-07-16 12:03 EDT, Paul Webster CLA 		no flags Details | Diff
keyAssist v02 (31.01 KB, patch)
2011-04-29 15:02 EDT, Paul Webster CLA 		no flags Details | Diff
keyAssist v03 (30.09 KB, patch)
2011-05-11 15:46 EDT, Paul Webster CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-06-17 11:19:42 EDT 
http://download.eclipse.org/e4/sdk/drops/I20100616-2127/index.php.

Key Assist (Ctrl+Shift+L) does not work.
Comment 1 Paul Webster CLA 2010-07-16 12:03:03 EDT 
Created attachment 174511 [details]
Work in Progress ... keyAssist v01
Comment 2 Remy Suen CLA 2010-12-09 10:33:12 EST 
*** Bug 332213 has been marked as a duplicate of this bug. ***
Comment 3 Paul Webster CLA 2011-03-11 08:43:54 EST 
Jesse, have a look at the key assist dialog.  You need a couple of things:

1) to support in in e4, there needs to be some way to hook into org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher.  See org.eclipse.ui.internal.keys.WorkbenchKeyboard in your 3.7 workspace. We can create a KeyAssistDialog in org.eclipse.e4.ui.bindings.  Or enhance org.eclipse.e4.ui.bindings.keys.KeyBindingDispatcher to be able to use a dialog contributed from somewhere else, where that somewhere else is the compatibility layer.

2) you need to be able to open the dialog with the list of active keybindings.

Once that works, then we need:

3) you need to be able to ask the EBindingService (runtime) if there are any conflicts.  That implies we need to be able to store conflicts in one BindingTable.  We also need to be able to report conflicts from 2 binding tables at the same context level (i.e. 2 sibling contexts, see org.eclipse.e4.ui.bindings.internal.ContextSet for a definition of level).

4) if there are conflicts, we need to be able to open the key assist dialog with the short list.

PW
Comment 4 Dani Megert CLA 2011-03-18 03:42:31 EDT 
*** Bug 340320 has been marked as a duplicate of this bug. ***
Comment 5 Paul Webster CLA 2011-04-29 15:02:05 EDT 
Created attachment 194395 [details]
keyAssist v02
Comment 6 Paul Webster CLA 2011-05-11 15:46:28 EDT 
Created attachment 195417 [details]
keyAssist v03

Slight cleanup of patch.

PW
Comment 7 Paul Webster CLA 2011-05-11 15:53:25 EDT 
(In reply to comment #6)
> Created attachment 195417 [details]
> keyAssist v03
> 

Released.  Thanx Jesse!

PW
Comment 8 Dani Megert CLA 2011-05-16 07:02:26 EDT 
Verified in 4.1 build: I20110515-0800: it only works partially: while I can bring up the dialog now, I cannot go to the preference page from there via Ctrl+Shift+L anymore. The hint is also missing. Filed bug 345916 to track that.
Comment 9 Dani Megert CLA 2011-05-16 09:34:40 EDT 
There's also bug 345946.