This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 317187 - Outline view menu and toolbar are empty
Summary: Outline view menu and toolbar are empty
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 4.1 M2   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 10:53 EDT by Dani Megert CLA
Modified: 2011-05-16 10:17 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-06-17 10:53:27 EDT 
http://download.eclipse.org/e4/sdk/drops/I20100616-2127/index.php.

The Outline view menu is empty if it shows the outline for the Java editor.
Comment 1 Yves YANG CLA 2010-06-17 12:28:30 EDT 
I guess it is the outline view of Visual Design editor. Please give more information about your environment and more description about the issue. The log file may be help as well.
Comment 2 Dani Megert CLA 2010-06-18 02:13:41 EDT 
>I guess it is the outline view of Visual Design editor.
Why do you guess when I tell you it's the 'Outline' view and the 'Java Editor'? I guess you don't know what the 'Outline' view is. ;-)

1. download the build from comment 0
2. install it
3. start with new workspace
4. paste the following line into the 'Package Explorer':
public class Test {}
5. make the 'Outline' view the active part
6. open the view menu (this is the little triangle on the top right)
==> view menu is empty (or even worse: shows a separator)
Comment 3 Yves YANG CLA 2010-06-18 04:25:03 EDT 
Sorry, I didn't pay attention on the last word.
Comment 4 Susan McCourt CLA 2010-07-08 17:29:55 EDT 
Still true in I20100707-2006.
The view menu of the outliner does not pop up.
There is also no view toolbar, so I can't sort, show public only, etc.
Comment 5 Dani Megert CLA 2010-07-13 08:51:55 EDT 
Now the view menu button also looks ugly (see bug 319702).
Comment 6 Paul Webster CLA 2010-07-13 15:17:14 EDT 
We're really close.  The trick is to always fill in the MRenderedToolBar in CompatibilityView with the actionBars ToolBarManager.

That way it's available at runtime for the dropdown menu, and when you open an editor with an outline page the correct ToolBarManager is being used and can then be displayed.

PW
Comment 7 Boris Bokowski CLA 2010-07-15 13:38:00 EDT 
Eric, is this on your radar? This bug is currently assigned to you.
Comment 8 Eric Moffatt CLA 2010-07-16 12:01:24 EDT 
It is now...;-).
Comment 9 Paul Webster CLA 2010-07-16 13:32:26 EDT 
I've committed a fix so that the outline menu is also available and filled in.

But switching editors removes the view dropdown menu icon and mis-lays out the new toolbar.  Resizing fixes the layout issue.

But I have to hide the outline view behind another view to get the view dropdown menu back.

PW
Comment 10 Boris Bokowski CLA 2010-07-16 15:56:46 EDT 
This looks good to me now. The toolbar layout issues were not related to this bug and have since been fixed by Bogdan.
Comment 11 Dani Megert CLA 2010-07-20 10:54:49 EDT 
>This looks good to me now. The toolbar layout issues were not related to this
>bug and have since been fixed by Bogdan.
Which build? I tried I20100718-2237 and there it's unusable since with every editor switch the view menu is gone.
Comment 12 Paul Webster CLA 2010-07-20 12:55:57 EDT 
(In reply to comment #10)
> This looks good to me now. The toolbar layout issues were not related to this
> bug and have since been fixed by Bogdan.

We still get into situations where the outline dropdown menu disappears.  It happens to other views as well.

PW
Comment 13 Dani Megert CLA 2010-09-22 04:24:11 EDT 
Looks fixed in I20100921-1710.
Comment 14 Dani Megert CLA 2010-09-22 04:24:19 EDT 
.