Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317120 - [NLS] DependencyGraphImpl can cause deadlock
Summary: [NLS] DependencyGraphImpl can cause deadlock
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Jason Sholl CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-16 17:37 EDT by Jason Sholl CLA
Modified: 2010-07-08 15:35 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
jsholl: pmc_approved? (raghunathan.srinivasan)
jsholl: pmc_approved? (naci.dai)
jsholl: pmc_approved? (deboer)
jsholl: pmc_approved? (neil.hauge)
jsholl: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
patch for 3.2.1 (35.32 KB, patch)
2010-06-16 17:38 EDT, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2010-06-16 17:37:11 EDT 
This is follow on work to bug 302644.

The attached patch redesigns the DependencyGraph to only consider raw dependencies, i.e. those that are hard coded in the .settings/org.eclipse.wst.common.component file.  The greatly simplifies the architecture and will completely eliminate deadlocks like those found in 302644.
Comment 1 Jason Sholl CLA 2010-06-16 17:38:41 EDT 
Created attachment 172078 [details]
patch for 3.2.1
Comment 2 Chuck Bridgham CLA 2010-06-16 17:54:06 EDT 
approve
Comment 3 Jason Sholl CLA 2010-06-21 14:53:00 EDT 
Requesting PMC approval for the following three strings.  These strings were previously burned into the code and would be displayed to the user in English only.  Now, they can be translated.

WAITING=Waiting
JOB_NAME=Graph Update
NOTIFICATION_JOB_NAME=Graph Update Notification
Comment 4 Jason Sholl CLA 2010-06-22 14:23:46 EDT 
code checked into head for WTP 3.2.1