Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317099 - [UI] Implement Detached Windows
Summary: [UI] Implement Detached Windows
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Project Inbox CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-16 14:29 EDT by Eric Moffatt CLA
Modified: 2010-06-24 15:28 EDT (History)
1 user (show)

See Also:


Attachments
Patch for the initial implementation (16.97 KB, patch)
2010-06-16 14:35 EDT, Eric Moffatt CLA
no flags Details | Diff
Patch to re-render the DW's correctly (1.66 KB, patch)
2010-06-18 09:35 EDT, Eric Moffatt CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2010-06-16 14:29:52 EDT
We need to at least mimic the existing DW behavior...
Comment 1 Eric Moffatt CLA 2010-06-16 14:35:07 EDT
Created attachment 172065 [details]
Patch for the initial implementation


This patch allows the creation of a detached window through dragging a view outside of the top-level window. Once created other views can be dragged into it as well.

Two cool features exist here:

You can have a whole PSC structure in a DW
Minimizing a stack in a DW will minimize it to the trim of its *owning* top-level window.

There's still work to be done on cleanup (i.e. closing the window hitting the 'x' or dragging the last view out of a DW...)
Comment 2 Eric Moffatt CLA 2010-06-16 14:37:16 EDT
Committed in >20100616. Applied the patch.
Comment 3 Eric Moffatt CLA 2010-06-18 09:35:51 EDT
Created attachment 172216 [details]
Patch to re-render the DW's correctly


The calculation of the ui container was wrong (was returning 'null' as the parent widget), leading to DW's being re-rendered as top-level shells rather than using the DW style...
Comment 4 Eric Moffatt CLA 2010-06-18 10:00:24 EDT
Committed in >20100618. Applied the patch.
Comment 5 Eric Moffatt CLA 2010-06-21 13:18:34 EDT
Need to stress test this...
Comment 6 Eric Moffatt CLA 2010-06-24 15:28:37 EDT
Marking as fixed, we can open new defects if testing finds new issues.