Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317075 - Wrong text in exception of MapProblemPreference
Summary: Wrong text in exception of MapProblemPreference
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 7.0   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 7.0.1   Edit
Assignee: Marc Khouzam CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-16 13:07 EDT by Marc Khouzam CLA
Modified: 2011-01-17 10:41 EST (History)
2 users (show)

See Also:
elaskavaia.cdt: review+

Attachments
Fix (1.79 KB, patch)
2010-06-16 13:07 EDT, Marc Khouzam CLA 		marc.khouzam: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Khouzam CLA 2010-06-16 13:07:42 EDT 
Created attachment 172060 [details]
Fix

I noticed that the wrong text was given to an exception in MapProblemPreference.

This patch should fix it.
Comment 1 Marc Khouzam CLA 2010-06-16 13:08:27 EDT 
Elena, does this make sense?
Comment 2 Elena Laskavaia CLA 2010-06-16 13:18:42 EDT 
yeah. Probably was refactoring to extract local variable without looking...
Comment 3 Marc Khouzam CLA 2010-06-16 15:42:59 EDT 
Committed to HEAD.
Elena, can you mark the review flag with a + if you are satisfied?
Comment 4 CDT Genie CLA 2010-06-16 16:23:06 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 317075: Wrong text to the exception

[*] MapProblemPreference.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/param/MapProblemPreference.java?root=Tools_Project&r1=1.6&r2=1.7
Comment 5 Elena Laskavaia CLA 2010-06-16 16:31:38 EDT 
I guess it is not worth committing to 7.0.1?
Comment 6 Marc Khouzam CLA 2010-06-16 17:15:34 EDT 
(In reply to comment #5)
> I guess it is not worth committing to 7.0.1?

I can if you want.
I can't commit it today though, because I don't have access the machine where I have my 7.0.1 branch environment.  It'll have to be tomorrow, unless you can take care of it.
Comment 7 Marc Khouzam CLA 2010-06-17 08:21:33 EDT 
Committed to 7.0.1
Comment 8 CDT Genie CLA 2010-06-17 09:38:04 EDT 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 317075: Wrong text passed to exception

[*] MapProblemPreference.java 1.6.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/param/MapProblemPreference.java?root=Tools_Project&r1=1.6&r2=1.6.2.1
Comment 9 Marc-André Laperle CLA 2011-01-11 00:11:54 EST 
(In reply to comment #7)
> Committed to 7.0.1

Target Milestone 7.0.1 then? :)
Comment 10 Marc Khouzam CLA 2011-01-17 10:41:13 EST 
Thanks M-A