Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 317061 - An exception is constructed but it's not thrown in method org.eclipse.cdt.codan.core.param.BasicProblemPreference#importValue(StreamTokenizer)
Summary: An exception is constructed but it's not thrown in method org.eclipse.cdt.cod...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-codan (show other bugs)
Version: 7.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 8.0   Edit
Assignee: Elena Laskavaia CLA
QA Contact: Elena Laskavaia CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-16 11:40 EDT by Meisam CLA
Modified: 2011-05-12 16:48 EDT (History)
1 user (show)

See Also:

Attachments
patch (860 bytes, patch)
2010-06-16 11:43 EDT, Meisam CLA 		cdtdoug: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Meisam CLA 2010-06-16 11:40:29 EDT 
"new IllegalArgumentException(e);" at line 131 doen't make sense.
Comment 1 Meisam CLA 2010-06-16 11:43:08 EDT 
Created attachment 172048 [details]
patch

Adds a throw keyword at the beginning of the statement.
Comment 2 Elena Laskavaia CLA 2010-06-16 20:35:16 EDT 
fixed on head
Comment 3 CDT Genie CLA 2010-06-16 21:23:07 EDT 
*** cdt cvs genie on behalf of elaskavaia ***
Bug 317061: fixed exception throwing

[*] BasicProblemPreference.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/param/BasicProblemPreference.java?root=Tools_Project&r1=1.7&r2=1.8
Comment 4 Doug Schaefer CLA 2011-05-12 16:48:25 EDT 
Comment on attachment 172048 [details]
patch

BTW, CVS genie helped me check whether the change matched the patch. Thanks Alena!