Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316954 - Refactor UI tests to be more reusable
Summary: Refactor UI tests to be more reusable
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 14:01 EDT by Dariusz Luksza CLA
Modified: 2010-06-18 09:31 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dariusz Luksza CLA 2010-06-15 14:01:49 EDT
Build Identifier: 

Re-usability of helper classes such as: WorkingCopyPage, RepoRemoteBranchesPage can be slightly improved by passing clone URL parameter (this is mentioned in comment for WorkingCopyPage.waitForCreate() method.

We can also distinguish a EGit UI base test class which will contains common for all SWTBot test cases @BeforeClass and @After methods.

Additionally we can move all helper classes into one package so that everything would be placed in one place.

Reproducible: Always
Comment 1 Dariusz Luksza CLA 2010-06-15 14:05:12 EDT
I've pushed a patch set to Gerrit:
http://egit.eclipse.org/r/873
Comment 2 Matthias Sohn CLA 2010-06-18 03:53:07 EDT
Dariusz:

for the IP review you need to make the following confirmations regarding this
contribution as a comment on this bug :

1.  authored 100% the content they are contributing
2.  have the rights to donate the content to EPL
3.  contribute the content under the EPL
Comment 3 Dariusz Luksza CLA 2010-06-18 04:06:06 EDT
(In reply to comment #2)
> 1.  authored 100% the content they are contributing

Yes, I'm author of 100% of content 

> 2.  have the rights to donate the content to EPL

Yes, I have full rights for this source code.

> 3.  contribute the content under the EPL

Yes, I'm contributing it under EPL
Comment 4 Matthias Sohn CLA 2010-06-18 09:31:27 EDT
merged as 4fec29460f0cd3d3a507fc5118815d991afd44cb