Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316895 - [Discoverer JEE] Code Factorisation for JEE Discoverer
Summary: [Discoverer JEE] Code Factorisation for JEE Discoverer
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Technologies (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9.0 M1   Edit
Assignee: Fabien Giquel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 09:07 EDT by Nicolas Guyomar CLA
Modified: 2010-10-18 08:29 EDT (History)
3 users (show)

See Also:
fabien.giquel: indigo+

Attachments
JEE Discoverer Factorisation (117.61 KB, patch)
2010-06-15 09:08 EDT, Nicolas Guyomar CLA 		no flags Details | Diff
JEE Discoverer Code Factorisation (106.39 KB, patch)
2010-06-17 06:56 EDT, Nicolas Guyomar CLA 		fabien.giquel: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Guyomar CLA 2010-06-15 09:07:40 EDT 
Hi,

In order to reduce the amount of code doing exactly the same thing (version detection or DTD detection, scheduling the editor opening) in the discovery of JEE Deploiement Descriptor file, I have factorized some methods from both webApp and ejbJar discoverer to org.eclipse.gmt.modisco.jee 

Regards

Nicolas
Comment 1 Nicolas Guyomar CLA 2010-06-15 09:08:48 EDT 
Created attachment 171922 [details]
JEE Discoverer Factorisation

This patch contains the factorisation of several methods redundant in JEE discoverer to org.eclipse.gmt.modisco.jee
Comment 2 Fabien Giquel CLA 2010-06-16 12:22:26 EDT 
Hi Nicolas,

there seems to be some problems with the patch :

- the class "DeployementDescriptorDiscoverer" does not exists in patch.
- the patch does not apply properly to the last ejbjar components from svn eclipse, please check the base version you were working on.

Thanks.
Fabien.
Comment 3 Nicolas Guyomar CLA 2010-06-17 06:56:53 EDT 
Created attachment 172105 [details]
JEE Discoverer Code Factorisation

Hi Fabien,

This is my fault, I forgot to synchronize my project for the SVN diff method to take in account new files

My mistake

This one should work

Nicolas
Comment 4 Fabien Giquel CLA 2010-06-17 07:00:55 EDT 
Hi Nicolas,

the patch has been commited into SVN. Thank for your contribution.

Fabien.
Comment 5 Fabien Giquel CLA 2010-06-21 10:04:28 EDT 
Nicolas,

Could you make the usual confirmations about contribution rights ?

Fabien.
Comment 6 Nicolas Guyomar CLA 2010-06-21 10:05:25 EDT 
Hi,

1. I, Nicolas Guyomar, and others contributors listed in this bug, authored
100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards

Nicolas
Comment 7 Hugo Bruneliere CLA 2010-10-04 13:39:54 EDT 
The patch has been successfully applied.