Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316855 - [CSS] Leaking background images
Summary: [CSS] Leaking background images
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 0.9   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Bogdan Gheorghe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-15 02:56 EDT by Thomas Schindl CLA
Modified: 2010-06-16 20:22 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2010-06-15 02:56:07 EDT 
Bogdan, I'm not sure why you commented the lines in GradientBackgroundListener where we are disposing the old resource. Too me this looks like a severe ResourceLeak.
Comment 1 Thomas Schindl CLA 2010-06-15 02:57:26 EDT 
The change was introduced with the commit for bug 314157. Can you clarify why you are not disposing of the old image?
Comment 2 Remy Suen CLA 2010-06-15 06:08:24 EDT 
I noticed this last night also.
Comment 3 Thomas Schindl CLA 2010-06-15 16:56:46 EDT 
Bogdan? Should we revert this change?
Comment 4 Bogdan Gheorghe CLA 2010-06-16 17:57:13 EDT 
The code was wrong as it was disposing images that it might have not created (as in the case of inheriting a background image from a parent). I have new code that keeps track of images created by the gradient listener and disposes of them at the proper time. (I checked for resource leaks and with the new code we're down to some jdt editor colors and the view menu image used by the stack renderer which Eric knows about).
Comment 5 Bogdan Gheorghe CLA 2010-06-16 20:22:39 EDT 
Fixed in HEAD > 20100618