Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316846 - Ecore Tools bundles missing about.html files
Summary: Ecore Tools bundles missing about.html files
Status: RESOLVED FIXED
Alias: None
Product: Ecoretools
Classification: Modeling
Component: General (show other bugs)
Version: -   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 blocker
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 316720
  Show dependency tree
 
Reported: 2010-06-14 21:46 EDT by Kenn Hussey CLA
Modified: 2011-05-20 05:17 EDT (History)
0 users

See Also:
Ed.Merks: pmc_approved+
Kenn.Hussey: pmc_approved+
Kenn.Hussey: pmc_approved? (cedric.brun)
Ed.Merks: review+
Kenn.Hussey: review+
Kenn.Hussey: review? (cedric.brun)

Attachments
proposed changes (5.13 KB, patch)
2010-06-14 22:12 EDT, Kenn Hussey CLA 		vincent.hemery: iplog+
Details | Diff
removal of index declaration (646 bytes, patch)
2010-06-15 10:00 EDT, Kenn Hussey CLA 		vincent.hemery: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenn Hussey CLA 2010-06-14 21:46:18 EDT 
As per bug 316720, the following bundles are missing about.html files in RC4:

org.eclipse.emf.ecoretools.doc
org.eclipse.emf.ecoretools.source

This is a regression, as the about.html files were included before switching over to the new Buckminster build.
Comment 1 Kenn Hussey CLA 2010-06-14 21:53:33 EDT 
After looking at the offending bundles, here are the reasons why the about.html files are missing:

org.eclipse.emf.ecoretools.doc

The custom build file is not being used by Buckminster, and since the build.properties file is empty (other than the 'custom=true'), the resulting bundle contains only a manifest.

org.eclipse.emf.ecoretools.source

The build.properties file is missing a src.includes directive that references about.html.

Patch to follow shortly...
Comment 2 Kenn Hussey CLA 2010-06-14 22:12:38 EDT 
Created attachment 171888 [details]
proposed changes
Comment 3 Ed Merks CLA 2010-06-15 00:58:47 EDT 
The patches are committed to CVS.
Comment 4 Kenn Hussey CLA 2010-06-15 09:59:33 EDT 
I've tested the resulting build and found that the index is actually empty (since all that's included in the "documentation" for Ecore Tools are a couple of hyperlinks). We'll need one more change to remove the index declaration.
Comment 5 Kenn Hussey CLA 2010-06-15 10:00:05 EDT 
Created attachment 171932 [details]
removal of index declaration
Comment 6 Ed Merks CLA 2010-06-15 15:39:01 EDT 
The fix is committed to CVS.