Community
Participate
Working Groups
Build Identifier: eclipse-SDK-3.6RC4-win32 When the Search Index is building, it constructs a series of help:// URLs for retrieving the index documents. With the introduction of remote help priority in Eclipse 3.6, help:// URLs first go to the remote information center to check for the content which causes the Search Index to make remote calls when building, unlike in releases previous to Eclipse 3.6 which would search locally first, and therefore never run into this problem. When the input stream for a help:// URL is read, Eclipse needs to know if this is an index call, and if so, search locally rather than honoring the remote priority preference. HelpURLConnection.getInputStream() is likely where the changes need to be made. Reproducible: Always Steps to Reproduce: 1. Navigate to Window -> Preferences -> Help -> Content and point to a remote infocenter. 2. Select the radio button "Include remote help and give it priority" 3. Open the help system via Help -> Contents, and do a search. The index will build, but will make remote calls for the remaining index documents (that weren't preindexed)
Created attachment 171999 [details] JUnit These two tests will check that no remote calls are made during an index operation - currently these tests fail because of this bug and will pass after it is fixed.
Created attachment 172002 [details] JUnits (version 2)
Created attachment 172071 [details] Patch
Reviewed the patch. Tested the local only case, as well as both remote priority options with positive results. The search index calls were interpreted as local only and avoided the incorrect remote call. This fix looks complete.
Patch applied to 3.6 maintenance stream, Fixed.