Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316818 - SecurityIdentityImpl.getDescription() and .setDescription() methods need to be updated
Summary: SecurityIdentityImpl.getDescription() and .setDescription() methods need to b...
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Aidyl Kareh CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 15:57 EDT by Aidyl Kareh CLA
Modified: 2010-06-17 17:10 EDT (History)
2 users (show)

See Also:
cbridgha: review+

Attachments
Proposed Patch (2.16 KB, patch)
2010-06-14 16:04 EDT, Aidyl Kareh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aidyl Kareh CLA 2010-06-14 15:57:18 EDT 
Build Identifier: WTP 3.2

The getDescription() and setDescription() methods in the SecurityIdentityImpl class should get/modify the first 'description' element if multiple description elements are allowed.

Reproducible: Always
Comment 1 Aidyl Kareh CLA 2010-06-14 16:04:48 EDT 
Created attachment 171869 [details]
Proposed Patch

Patch updated the getDescription() and setDescription() methods in the SecurityIdentityImpl class to get/modify the first 'description' element if multiple description elements are allowed.
Comment 2 Chuck Bridgham CLA 2010-06-15 21:59:43 EDT 
approved
Comment 3 Carl Anderson CLA 2010-06-17 17:10:34 EDT 
Committed to HEAD for WTP 3.2.1, but with one minor change:

I replaced the call to String.isEmpty() with String.length() < 1

This is due to the fact that String.isEmpty() is new to Java 6, and WTP is still compiled with/compatible with Java 5.