Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316802 - e4 variant of contributing to toolbars
Summary: e4 variant of contributing to toolbars
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0 RC1   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 316295
  Show dependency tree
 
Reported: 2010-06-14 14:43 EDT by Remy Suen CLA
Modified: 2010-06-28 13:31 EDT (History)
0 users

See Also:

Attachments
Tool bar contribution patch v1 (32.12 KB, patch)
2010-06-15 16:23 EDT, Remy Suen CLA 		no flags Details | Diff
Tool bar contribution patch v2 (49.74 KB, patch)
2010-06-24 15:55 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2010-06-14 14:43:38 EDT 
Need a toolbar/trim variants of MMenuContribution.
Comment 1 Remy Suen CLA 2010-06-15 16:23:20 EDT 
Created attachment 171988 [details]
Tool bar contribution patch v1

Well, the 'Plug-ins' view has a command tool bar contribution now.
Comment 2 Remy Suen CLA 2010-06-16 05:07:32 EDT 
Command contributions to the trim now work. Why they appear in the "right place" on subsequent runs is a mystery to me. On startup they appear in the beginning.
Comment 3 Remy Suen CLA 2010-06-16 05:18:34 EDT 
(In reply to comment #2)
> Why they appear in the "right
> place" on subsequent runs is a mystery to me. On startup they appear in the
> beginning.

In the first case, the model is completely rendered before parts are created. In this case, the model is pretty bare, just a window with trim bars.

In the latter case, the model has parts in it and the 4.0 implementation requires workbench windows to operate during part construction so the workbench window is instantiated before the trim bars are rendered.
Comment 4 Remy Suen CLA 2010-06-18 10:09:27 EDT 
Main trim contribution were not showing up in new workbench windows (but do on a restart). This has been fixed.
Comment 5 Remy Suen CLA 2010-06-24 15:55:27 EDT 
Created attachment 172678 [details]
Tool bar contribution patch v2

Adds [all] 3.x actionSets into the toolbar.

There's also a problem where the perspective switcher gets into the middle. Not totally sure yet what's going on there just yet.
Comment 6 Remy Suen CLA 2010-06-24 15:55:56 EDT 
(In reply to comment #5)
> Created an attachment (id=172678) [details]
> Tool bar contribution patch v2

Released to HEAD.
Comment 7 Remy Suen CLA 2010-06-24 16:15:26 EDT 
(In reply to comment #5)
> There's also a problem where the perspective switcher gets into the middle. Not
> totally sure yet what's going on there just yet.

This shouldn't happen anymore I think.
Comment 8 Remy Suen CLA 2010-06-25 07:56:32 EDT 
(In reply to comment #5)
> Adds [all] 3.x actionSets into the toolbar.

They should be dependent on the perspective now...to an extent.
Comment 9 Paul Webster CLA 2010-06-28 13:31:51 EDT 
The e4 version is available, MTrimContributions to add Toolbars and controls, and the MToolBarContributions to contribute to toolbars (in the trim or parts).

PW