Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316792 - Toolbar images should be center aligned
Summary: Toolbar images should be center aligned
Status: RESOLVED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.0 RC0   Edit
Assignee: Project Inbox CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 13:42 EDT by Bogdan Gheorghe CLA
Modified: 2010-06-21 16:26 EDT (History)
1 user (show)

See Also:

Attachments
Patch to center trim elements (1.26 KB, patch)
2010-06-14 13:51 EDT, Eric Moffatt CLA 		no flags Details | Diff
Patch that allows margins and inter-line spacing (4.71 KB, patch)
2010-06-14 15:15 EDT, Eric Moffatt CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bogdan Gheorghe CLA 2010-06-14 13:42:08 EDT 
Currently if one of the children controls on the trim bar causes the trim bar height to grow, the other controls on the bar are aligned at the top. They should be center aligned.
Comment 1 Eric Moffatt CLA 2010-06-14 13:51:13 EDT 
Created attachment 171854 [details]
Patch to center trim elements
Comment 2 Eric Moffatt CLA 2010-06-14 15:15:14 EDT 
Created attachment 171862 [details]
Patch that allows margins and inter-line spacing


Still have to add code for spaces between the controls on the same tiled line...
Comment 3 Eric Moffatt CLA 2010-06-14 15:16:11 EDT 
Committed in >20100614. Applied the patch.
Comment 4 Eric Moffatt CLA 2010-06-21 13:07:44 EDT 
Marking as FIXED, we should open a separate defect if we decide to have spacing between the elements in a line.