Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316779 - Deependency on device.common.utilities added to android plugins
Summary: Deependency on device.common.utilities added to android plugins
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sequoyah (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Core tml inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 11:34 EDT by Doug Schaefer CLA
Modified: 2016-11-08 14:45 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Schaefer CLA 2010-06-14 11:34:15 EDT 
This looks like a organize includes that went bad. But I see a number of calls to BasePlugin log utilities from the android plugins. These should be added to the Activators of the plugin where the things that need to be logged.
Comment 1 Doug Schaefer CLA 2010-06-16 21:45:27 EDT 
Hmm. I'm not sure I like the code style you guys are using. It strays pretty far from the Eclipse standard we've used for years on the CDT, not to mention the standard Java source formatter.

At any rate, I've added log methods to the UIPlugin and moved the calls to them. And I've checked it in so I can get unblocked.
Comment 2 Doug Schaefer CLA 2010-06-16 21:45:44 EDT 
Marking fixed.
Comment 3 Daniel Drigo Pastore CLA 2010-06-18 13:06:00 EDT 
Hi Doug,

(In reply to comment #1)
> At any rate, I've added log methods to the UIPlugin and moved the calls to
> them. And I've checked it in so I can get unblocked.

Are these changes in your commit #2167? 
Shouldn't we have a patch posted here?

Thanks,

Daniel Pastore
Comment 4 Doug Schaefer CLA 2010-06-18 13:13:13 EDT 
(In reply to comment #3)
> Hi Doug,
> 
> (In reply to comment #1)
> > At any rate, I've added log methods to the UIPlugin and moved the calls to
> > them. And I've checked it in so I can get unblocked.
> 
> Are these changes in your commit #2167? 
> Shouldn't we have a patch posted here?
> 
> Thanks,
> 
> Daniel Pastore

I have very little time to devote to this project so you'll likely see things like that happen from me. If I see something broken I'll raise a bug and if it's blocking and taking too long to get fixed, like this one, I'll just fix it.