Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316774 - coalesce can not be overwritten by a db-platform
Summary: coalesce can not be overwritten by a db-platform
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Server 2003
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 284657
  Show dependency tree
 
Reported: 2010-06-14 11:19 EDT by Andreas Fischbach CLA
Modified: 2022-06-09 10:32 EDT (History)
4 users (show)

See Also:

Attachments
Rought Suggestion for a fix (2.91 KB, application/octet-stream)
2010-10-01 10:43 EDT, Tom Ware CLA 		no flags Details
Rough patch (16.85 KB, patch)
2010-10-04 16:33 EDT, Tom Ware CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Fischbach CLA 2010-06-14 11:19:22 EDT 
ExpressionOperator.coalesce can be overwritten by a platform, but it has no effect, cause Expression.coalesce is used at the end and the latter can not be configured for other platforms. 
MaxDB requires another functionname for coalesce
Comment 1 Tom Ware CLA 2010-06-18 12:44:28 EDT 
Setting initial target and priority.  Please feel free to change either of
these values when you know what the target is.
Comment 2 Tom Ware CLA 2010-10-01 10:43:39 EDT 
Created attachment 180062 [details]
Rought Suggestion for a fix

I am attaching a patch that should allow coalesce to be overridable.  I have done some minimal testing on it, but it it still needs full testing.
Comment 3 Tom Ware CLA 2010-10-04 16:33:38 EDT 
Created attachment 180207 [details]
Rough patch

adding a prototype for a patch.  testing and review is still required.
Comment 4 Adrian Goerler CLA 2010-10-06 07:03:56 EDT 
Tested successfully on MaxDB, which requires overwriting "COALESCE" by "VALUES".

As we are targeting the MaxDB platform for 2.2, we'd need this patch in 2.2 as well.
Comment 5 Tom Ware CLA 2010-10-07 10:40:24 EDT 
Fixed in trunk.

The fix changes coalesce, case, and caseCondition to get their Operator by lookup instead of creating it each time it is called.  The fix also makes some changes to the flow in ArgumentListExpressionOperator to allow it to be overridden.

Tested manually.  Automated testing coming with implementation of bug 284657.

Reviewed by Chris Delahunt
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:16:44 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink
Comment 7 Eclipse Webmaster CLA 2022-06-09 10:32:05 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink