Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316761 - WindowCachePreferencePage allows to save invalid value
Summary: WindowCachePreferencePage allows to save invalid value
Status: CLOSED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows Vista
: P3 critical (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 10:26 EDT by Mathias Kinzler CLA
Modified: 2010-06-18 10:27 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Kinzler CLA 2010-06-14 10:26:27 EDT 
It is possible to store a value of "2 k" for the "Team->Git->Window Cache" preference page, field "Window size". Unfortunately, the value is persisted before it is validated. When calling the preference page again, an error pop-up will be displayed very shortly, and the new value will not be stored again (i.e. it is not possible to correct that value anymore).
What's worse, when the IDE is re-started, the wrong value makes the JGit plug-in fail upon start, so it is impossible to recover from this situation without losing the workspace.
A fix should do two things:
1. make the plug-in start more forgiving
2. make sure to assert correctness of the configuration value before storing them
Comment 1 Mathias Kinzler CLA 2010-06-15 05:18:57 EDT 
Code review at
http://egit.eclipse.org/r/#change,871
Comment 2 Mathias Kinzler CLA 2010-06-18 10:27:31 EDT 
Merged as 13110abd2a8a9d0843cf24a08ab32a0b3b270fb2