Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316680 - jgit-cli log command should support --maxcount
Summary: jgit-cli log command should support --maxcount
Status: RESOLVED FIXED
Alias: None
Product: JGit
Classification: Technology
Component: JGit (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Christian Halstrick CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 357774
  Show dependency tree
 
Reported: 2010-06-12 07:54 EDT by Denny Valliant CLA
Modified: 2011-12-23 13:28 EST (History)
3 users (show)

See Also:

Attachments
patch file adding CommitCountRevFilter (4.02 KB, patch)
2010-06-12 07:56 EDT, Denny Valliant CLA 		no flags Details | Diff
simple test for CommitCountRevFilter (1.78 KB, patch)
2010-06-12 07:58 EDT, Denny Valliant CLA 		no flags Details | Diff
adds the --max-count argument (1.86 KB, patch)
2010-06-12 08:01 EDT, Denny Valliant CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Denny Valliant CLA 2010-06-12 07:54:28 EDT 
Build Identifier: 

jgit-cli log command should support --maxcount

Seems like the way to do this would be to create a RevFilter for counting commits.

Which is what I did.  CommitCountRevFilter has max(int) for limiting results.  Doubt anyone would want min(int) or some such, but that was the thinking.

Reproducible: Always
Comment 1 Denny Valliant CLA 2010-06-12 07:56:26 EDT 
Created attachment 171780 [details]
patch file adding CommitCountRevFilter
Comment 2 Denny Valliant CLA 2010-06-12 07:58:16 EDT 
Created attachment 171781 [details]
simple test for CommitCountRevFilter
Comment 3 Denny Valliant CLA 2010-06-12 08:01:18 EDT 
Created attachment 171782 [details]
adds the --max-count argument
Comment 4 Christian Halstrick CLA 2011-07-07 10:48:54 EDT 
You should propose this change to gerrit [1] as described in our contributors guide [2]. I can help you with that or do that for you. Please tell what you prefer.
Comment 5 Tomasz Zarna CLA 2011-12-15 05:49:20 EST 
Pushed a changeset as http://egit.eclipse.org/r/4827, didn't use Denny's patches.
Comment 6 Robin Rosenberg CLA 2011-12-23 13:28:49 EST 
248959146a383ecbcd6e55919a9595c3b3b7467d merged