Community
Participate
Working Groups
The manual launch option is not supported and thus should be removed from the GUI. As an alternative it should be implemented. The manual launch would be useful if there is no other way to specify additional arguments. Currently the PBS proxy itself does not accept additional arguments but it is conceivable that we might e.g. add the option to pass a -debug argument. Already now it is useful to pass additional JVM options (e.g. -Xdebug). Currently those have to be added to the proxy.xml. Thus for debugging purposes either the manual launch or the additional arguments should work (Bug 316054). I would prefer to get the additional arguments to work and to remove the manual launch.
I suggest 1) Remove the manual launch option from the GUI (only for PBS/Jproxy) 2) Show the full remoteServer launchCommand in the Proxy Option dialog (with the placeholders) This would allow to specify additional java arguments, command arguments and the location of the java binary. And we wouldn't need to implement manual launch. Is this OK?
In order to avoid significant changes to the server launch code, I'd suggest implementing (2) using variables, since these are already used. The default launch command would be stored in the variable ${launchCommand} which could be modified by the RM configuration wizard. The manual launch option is useful when you want to be able to start the server under the control of a debugger, rather than attach at a later point (and possibly miss something in the startup code). It is also useful for testing if there are firewall problems (though not for tunneling). I don't have any objections if you want to remove it though, since it is really only there for debugging purposes.
(In reply to comment #2) > In order to avoid significant changes to the server launch code, I'd suggest > implementing (2) using variables, since these are already used. The default > launch command would be stored in the variable ${launchCommand} which could be > modified by the RM configuration wizard. For now I have only implemented that one can add jvm arguments. This is enough for debugging. If we think we need also the option to specify the path to the java binary than we should do that in a that it also changes the verifyCommand. Thus their should be a jvmpath variable which is used in both.
deactivating manual launch: committed to HEAD (required API change) allow setting debug option: committed to HEAD+ptp4
