Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316665 - [assist] create method from unresolved replace callin RHS adds "callin" modifier
Summary: [assist] create method from unresolved replace callin RHS adds "callin" modifier
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 0.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.7   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 19:57 EDT by Stephan Herrmann CLA
Modified: 2011-05-15 09:55 EDT (History)
0 users

See Also:

Attachments
test & fix (5.01 KB, patch)
2010-06-13 05:23 EDT, Stephan Herrmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2010-06-11 19:57:32 EDT 
When the base method spec of a replace callin is unresolved,
the quickfix for creating this method in the base class wrongly
adds the callin modifier.
Comment 1 Stephan Herrmann CLA 2010-06-13 05:23:29 EDT 
Created attachment 171797 [details]
test & fix

This patch checks whether the unresolved method spec, on which' behalf
the quick fix is started, is the role-side. Only if so is a "callin"
modifier ever inserted.

Additionally, I made sure that no add-cast proposals are created
for generated variabls (starting with "_OT$"). The test had produced
a proposal to add a cast to "_OT$base".
Comment 2 Stephan Herrmann CLA 2010-06-13 05:30:34 EDT 
Patch was committed as r475 + r476.
Comment 3 Stephan Herrmann CLA 2010-07-02 12:52:39 EDT 
Verified using build 201007011455.