Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316648 - Run rpmlint menu contribution appears where it shouldn't
Summary: Run rpmlint menu contribution appears where it shouldn't
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: RPM (show other bugs)
Version: 0.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.7   Edit
Assignee: Alexander Kurtakov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 15:27 EDT by Andrew Overholt CLA
Modified: 2010-10-26 06:47 EDT (History)
1 user (show)

See Also:

Attachments
Test patch for 316648 (586 bytes, patch)
2010-06-14 11:30 EDT, Charley Wang CLA 		akurtakov: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2010-06-11 15:27:08 EDT 
I just noticed that a plain text editor with a .stp file loaded has "Run rpmlint" in the context menu.  We should restrict this to the .spec editor and RPM projects.
Comment 1 Charley Wang CLA 2010-06-14 11:30:20 EDT 
Created attachment 171837 [details]
Test patch for 316648

Result: Only activate rpmlint action if the file was opened in the specfile editor. This means if a user manually chooses to open the .spec file with a different editor they will not see the rpmlint menu contribution in the editor's context menu. 

I'll keep looking for a way to grab the filename which would be better, the standard technique doesn't seem to be working.
Comment 2 Alexander Kurtakov CLA 2010-10-26 06:43:11 EDT 
Applied in r 25550.