Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316585 - Wrong name for JSF plugins in helios update site
Summary: Wrong name for JSF plugins in helios update site
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: 3.2   Edit
Hardware: Other All
: P3 normal (vote)
Target Milestone: 3.2.1   Edit
Assignee: Raghunathan Srinivasan CLA
QA Contact:
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-11 06:23 EDT by Robin Rosenberg CLA
Modified: 2017-12-19 13:26 EST (History)
2 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved? (naci.dai)
deboer: pmc_approved+
raghunathan.srinivasan: pmc_approved? (neil.hauge)
raghunathan.srinivasan: pmc_approved? (kaloyan)

Attachments
Fix for org.eclipse.jsf.feature.source.feature.group name (891 bytes, text/plain)
2010-06-11 17:26 EDT, Raghunathan Srinivasan CLA 		no flags Details
Fix for Test feature name (664 bytes, text/plain)
2010-06-11 17:26 EDT, Raghunathan Srinivasan CLA 		no flags Details
Fix for org.eclipse.jsf.feature.source.feature.group (1.07 KB, patch)
2010-06-11 19:13 EDT, Raghunathan Srinivasan CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg CLA 2010-06-11 06:23:38 EDT 
JavaServer Faces Tools is listed with the name "name" in the update manager 

Update site: http://download.eclipse.org/webtools/repository/helios

Feature list:

feature.name	3.2.0.v20100524-7E7W1FBBoPbPQIiTa3454
name	3.2.0.v20100526-7E7I-F9JgLWLM7g63114
Comment 1 David Williams CLA 2010-06-11 13:07:23 EDT 
This is bad ... but ... it is only for 'test' feature (right?) 

I notice another problem is that both JSF (non-sdk) feature, and the JSF SDK feature are in the non-sdk category ... and JSF SDK does not show up in the SDK category.
Comment 2 Robin Rosenberg CLA 2010-06-11 15:21:28 EDT 
The seconds one "name" is not a test feature, I think.
Comment 3 David Williams CLA 2010-06-11 16:22:31 EDT 
(In reply to comment #2)
> The seconds one "name" is not a test feature, I think.

Ah, I see it now. It was not in a category, but if I removed categories, I could find it. It belongs to jsf source feature. 

org.eclipse.jsf.feature.source.feature.group

Must be something amiss in the "sourceFeatureTemplate" folder. 

For the test one, '%feature.name' in the feature.xml file should be '%name'. 

Raghu, I suggest you target this for maintenance. Since doesn't effect the common repo, and the "test" one is not visible in products, this does not seem worth a respin. 

I have opened bug 316651 to handle the category problem (that's in a category.xml file, in releng.wtpbuilder). 

Thank you for reporting.
Comment 4 Raghunathan Srinivasan CLA 2010-06-11 17:26:06 EDT 
Created attachment 171772 [details]
Fix for org.eclipse.jsf.feature.source.feature.group name
Comment 5 Raghunathan Srinivasan CLA 2010-06-11 17:26:49 EDT 
Created attachment 171773 [details]
Fix for Test feature name
Comment 6 Raghunathan Srinivasan CLA 2010-06-11 17:39:12 EDT 
Agreed on the test feature. I am assuming the SDK feature name is not going to be an issue for an adopter.
Comment 7 David Williams CLA 2010-06-11 18:47:13 EDT 
The provider name should be "Eclipse Web Tools Platform". 
Just as well fix it too, since toughing the file.
Comment 8 Raghunathan Srinivasan CLA 2010-06-11 19:13:04 EDT 
Created attachment 171775 [details]
Fix for org.eclipse.jsf.feature.source.feature.group
Comment 9 Raghunathan Srinivasan CLA 2010-07-08 14:49:44 EDT 
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Incorrect name of the JSF feature in the update manager.
    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
no
    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
manual
    * Give a brief technical overview. Who has reviewed this fix? 
see comment 3
    * What is the risk associated with this fix? 
none-low
Comment 10 David Williams CLA 2010-07-08 16:09:52 EDT 
remember to put "PMC" in whiteboard, to get it to show up on summary page.
Comment 11 Raghunathan Srinivasan CLA 2010-07-13 14:35:46 EDT 
Change released to 3.2.1
Comment 12 Eclipse Genie CLA 2017-12-18 20:16:12 EST 
New Gerrit change created: https://git.eclipse.org/r/114239