Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 316550 - AbstractRemoteServerRunner.launchServer picks wrong payload
Summary: AbstractRemoteServerRunner.launchServer picks wrong payload
Status: RESOLVED FIXED
Alias: None
Product: PTP
Classification: Tools
Component: Remote Tools (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Greg Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-10 18:16 EDT by Roland Schulz CLA
Modified: 2010-06-11 10:27 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Schulz CLA 2010-06-10 18:16:10 EDT 
I had both the dstore server and the PBS proxy running and tried to restart the PBS proxy. I got:

Unable to locate payload "rdt-server.jar" in bundle "org.eclipse.ptp.rm.pbs.jproxy"

Restarting it a few more times, I got every time the same error.

After I restarted the workbench it worked and I couldn't reproduce the error. 

I looked at the code and don't understand how the getPayload call works to get the payload from the correct plugin.
Comment 1 Greg Watson CLA 2010-06-11 10:26:46 EDT 
RemoteServerManager#getServer searches for the extension point with the correct ID of the server. If one is found, the bundle ID of the declaring bundle is retrieved along with the command and payload. AbstractRemoteServerRunner#launchServer then uses the bundle ID to locate the payload.

However, it looks like it should be using getContributor().getName() instead of getDeclaringExtension().getNamespaceIdentifier() so this may have caused the problem. The javadoc for IConfigurationExtension#getNamespace seems to imply that the wrong ID could be returned (for our purposes), although it's not exactly clear what these circumstances might be.

Fixed in HEAD.